User talk:AMDmi3

From OpenStreetMap Wiki
Jump to: navigation, search

I have two small suggestions to glosm:

  • for buildings without any height or levels information, assume it is some small building (for example 3 meters high), so it will show at least somehow on the map
my plans are to not make any guesses/assumptions on data which isn't in the base. Such guesses will be erroneous in most cases anyway, but it will look like the area is well mapped and discourage users from editing. That's only for now though - when glosm develop into something more user-oriented this can be done, drawn with dashed lines or something like that. --AMDmi3 21:01, 11 February 2011 (UTC)
  • It would be nice to show also towers - those are tagged by man_made=tower and usually they do not have a building tag.
Done, also chimneys. Only area objects are supported for now. --AMDmi3 21:01, 11 February 2011 (UTC)

Here are the suggestons translated into machine readable code :) :

diff --git a/libglosm-geomgen/src/GeometryGenerator.cc b/libglosm-geomgen/src/GeometryGenerator.cc
index ae2a548..c252619 100644
--- a/libglosm-geomgen/src/GeometryGenerator.cc
+++ b/libglosm-geomgen/src/GeometryGenerator.cc
@@ -404,7 +404,7 @@ static float GetMaxHeight(const OsmDatasource::Way& way) {
                return h;
        }

-       return 0.0;
+       return 3.0;
 }

 static float GetMinHeight(const OsmDatasource::Way& way) {
@@ -487,7 +487,7 @@ static void WayDispatcher(Geometry& geom, const OsmDatasource& datasource, const
        for (OsmDatasource::Way::NodesList::const_iterator n = way.Nodes.begin(); n != way.Nodes.end(); ++n)
                vertices.push_back(datasource.GetNode(*n).Pos);

-       if ((way.Tags.find("building") != way.Tags.end() || way.Tags.find("building:part") != way.Tags.end()) && minz != maxz) {
+       if ((way.Tags.find("building") != way.Tags.end() || way.Tags.find("building:part") != way.Tags.end()||((t = way.Tags.find("man_made")) != way.Tags.end() && t->second == "tower")) && minz != maxz) {
                CreateWalls(geom, vertices, minz, maxz, way);
                CreateRoof(geom, vertices, maxz, way);


--Bilbo 15:49, 11 February 2011 (UTC)

suggstion for roof name

In File:Roofs.png, the "(needs naming)" roof could be called a frustrum. Also, it's not immediately clear that the second pitched roof (with the ridge across). Maybe it could have an explicit label as well. Cheers, Waldir (talk) 03:21, 21 June 2013 (UTC)

That image may be counted as deprecated. Actual scheme uses slightly different tag values and doesn't use this picture: http://wiki.openstreetmap.org/wiki/Key:roof:shape, you can instead add it there. --AMDmi3 (talk) 18:43, 21 June 2013 (UTC)

man_made=tunnel

Hi AMDmi3, some time ago you mentioned that it would be helpful to create a tag that is similar to man_made=bridge. I've started writing a proposal, see Proposed features/man made=tunnel. Please review and comment! --Biff (talk) 19:41, 18 May 2016 (UTC)