User talk:Liosha

From OpenStreetMap Wiki
Jump to: navigation, search

osm2mp feedback

Hi there,

thanks for osm2mp, it's been very useful in testing routing support in mkgmap. There's some feedback on Talk:mkgmap/routing that relates to osm2mp -- maybe you're interested. Here's a patch to make osm2mp recognize access=no:

--- osm2mp.pl	(revision 12)
+++ osm2mp.pl	(working copy)
@@ -372,6 +372,11 @@
 
        $polydir    = $yesno{$2}                 if ($1 eq "oneway");
        $polytoll   = $yesno{$2}                 if ($1 eq "toll");
+
+       if ($1 eq "access")
+           $polynoauto = $polynobus = $polynoped
+                = $polynobic = $polynohgv = 1 - $yesno{$2};
+
        $polynoauto = 1 - $yesno{$2}             if ($1 eq "motorcar");
        $polynobus  = 1 - $yesno{$2}             if ($1 eq "psv");
        $polynoped  = 1 - $yesno{$2}             if ($1 eq "foot");

Cheers, Robx 09:00, 7 December 2008 (UTC)

Thanks, i'll fix it with next commit. --Liosha 12:06, 7 December 2008 (UTC)

Hi Liosha, I also made some changes to osm2mp. The patch is at User:abunai/osm2mp if you're interested. --abunai 19:58, 7 December 2008 (UTC)

Thanks. I've added some of them and have committed new revision to svn. But i don't think that using empty codepage is good idea. You can use 1252 for western european langs. --Liosha 20:28, 7 December 2008 (UTC)
I've added "--nocodepage" option to leave all labels in utf-8. --Liosha 20:46, 7 December 2008 (UTC)
Thanks! (I think when a road has both a number and a name, it could be useful to display both. Maybe make that an option too? :) --abunai 21:07, 7 December 2008 (UTC)
I have also expanded the POI list, at User:abunai/osm2mp. --abunai 01:01, 8 December 2008 (UTC)
Ok, added. --Liosha 08:28, 8 December 2008 (UTC)

Hi Liosha, found following "bug" in OSM2MP rev.17

 Index: poi.cfg
 ===================================================================
 --- poi.cfg	(revision 17)
 +++ poi.cfg	(working copy)
 @@ -185,7 +185,7 @@
  shop            convenience             0x2E02
  shop            doityourself            0x2E09
  shop            dry_cleaning            0x2F00
 -shop            grocery                 022E02
 +shop            grocery                 0x2E02
  shop            kiosk                   0x2E02
  shop            laundry                 0x2F00
  shop            outdoor                 0x2E06

--Dido 21:39, 8 December 2008 (UTC)

Fixed. --Liosha 05:14, 9 December 2008 (UTC)

motorroad, bakery

Hi,

could you add support for motorroad=yes, which implies bicycle=no and foot=no? I think this should do:

Index: osm2mp.pl
===================================================================
--- osm2mp.pl   (Revision 27)
+++ osm2mp.pl   (Arbeitskopie)
@@ -514,6 +514,7 @@
        $polynohgv  = 1 - $yesno{$2}             if ($1 eq "hgv");
        $polynoauto = $polynobus = $polynoped = $polynobic = $polynohgv = 1 - $yesno{$2}
                                                 if ($1 eq "access");
+       $polynobic = $polynoped = 1             if ($1 eq "motorroad") and $yesno{$2};

        next;
    }

By the way, I think would be better to tag a bakery like a café etc. than as a generic shop:

Index: poi.cfg
===================================================================
--- poi.cfg     (Revision 27)
+++ poi.cfg     (Arbeitskopie)
@@ -176,7 +176,7 @@
 railway         turntable
 railway         viaduct                 0x6401

-shop            bakery                  0x2E02
+shop            bakery                  0x2A0E
 shop            bicycle                 0x2F00
 shop            butcher                 0x2E02
 shop            car                     0x2F07
fixed. --Liosha 06:23, 26 January 2009 (UTC)