Proposal:Manufacturer and Model
| The Feature Page for the approved proposal Manufacturer is located at Key:manufacturer |
| The Feature Page for the approved proposal Model is located at Key:model |
| Manufacturer and Model | |
|---|---|
| Proposal status: | Approved (active) |
| Proposed by: | Danysan |
| Applies to: |  
|
| Definition: | Standardization of the tagging of manufacturer and model of artificial elements |
| Draft started: | 2022-03-27 |
| RFC start: | 2022-03-27 |
| Vote start: | 2022-11-13 |
| Vote end: | 2022-11-27 |
Proposal
- Mark these keys as deprecated:
- manufacturer:type=* (in favor of model=*)
- vehicle:wikidata=* (in favor of model:wikidata=*)
- vehicle:wikipedia=* (in favor of model:wikipedia=*)
- Update related wiki pages to mark the above keys as obsolete
- Update related wiki pages to add references to the correct keys
Rationale
There are many tags which represent an type of artificial object which has a manufacturer and a model.
With "model" we intend here a designation that allows to distinguish a class of objects with the same design and/or charateristics amongst those produced by the same manufacturer. Generic classifications which are not limited to a single manufacturer don't belong here and are already handled by domain-specific tags (for example aircraft:type=* for historic=aircraft) (more details about this in the discussion page).
Some of the features that can have a manufacturer and a model are:
- emergency=siren
- highway=elevator
- historic=aircraft
- historic=locomotive
- historic=railway_car
- historic=tank
- historic=vehicle
- man_made=pump
- man_made=street_cabinet
- power=generator
- ...
Current situation
Tags manufacturer=* and model=* are already approved to represent the informations of manufacturer and model. Currently however there is some confusion about the keys which can be used for this purpose:
Recap of keys to represent the manufacturer:
Recap of keys to represent the model:
Other minor keys can be found at https://taginfo.openstreetmap.org/keys/model#similar .
Sometimes this confusion can lead to mapping errors. For example a lot of historic=vehicle and historic=tank are mapped using name=*, wikidata=* and wikipedia=* to represent their model, as can be seen with the Overpass query https://overpass-turbo.eu/s/1h9E and with the Sophox query https://tinyurl.com/y9744cgq . This is clearly wrong, as name=*, wikidata=* and wikipedia=* should represent the object itself and not its model or some other charateristic. Reading from their wiki page it appears that vehicle:wikidata=* and vehicle:wikipedia=* were born to fix this, but
- these tags don't yet seem to be much used
- these tags violate the standard meaning of the suffixes *:wikidata=* and *:wikipedia=* as defined by Key:wikidata#Secondary_Wikidata_links and Key:wikipedia#Secondary_Wikipedia_links, as vehicle=* is already used for another purpose
- the fact that vehicle=* is already used for another purpose doesn't allow to specify the plain text name of the vehicle model and this could lead to use name=* for the model name, which is wrong as name=* should be used for the instance own name
Rationale of the proposal
The objective of this proposal is to create a common standard to represent manufacturer, model and related Wiki links across all element types which are an instances of a model.
Given that the manufacturer=* and model=* keys are already used and approved and their wiki pages describe correctly they will remain the reference tags.
For both of them there is the possibility to add a link to wikidata or wikipedia through the tags manufacturer:wikidata=*, manufacturer:wikipedia=*, model:wikidata=* and model:wikipedia=*. manufacturer:wikidata=* is already documented in Key:manufacturer:wikidata, while for the other three tags the auto-generated pages Key:manufacturer:wikipedia, Key:model:wikidata and Key:model:wikipedia already explain sufficiently well the meaning of the combination.
I propose to update the wiki pages cited above to clean up the confusion and suggest the use manufacturer=* and model=* instead of the previous alternatives. In the case of manufacturer:type=*, vehicle:wikidata=* and vehicle:wikipedia=* I also propose the deprecation. On the other side, I don't propose the deprecation of other *:model=* subkeys because the world is full of edge cases where someone could want to tag separately different parts of elements that to the outsider look one single piece (more details about this in the discussion page).
Tagging
| Key | Element | Description | Count | Example |
|---|---|---|---|---|
| manufacturer=* |
|
Manufacturer | historic=aircraft + manufacturer=Boeing | |
| manufacturer:wikidata=* |
|
Q-ID of the Wikidata element representing the manufacturer (standard meaning of the suffix as defined by Key:wikidata#Secondary_Wikidata_links) | historic=aircraft + manufacturer=Boeing + manufacturer:wikidata=Q66 | |
| manufacturer:wikipedia=* |
|
Localized title of the Wikipedia page describing the manufacturer (standard meaning of the suffix as defined by Key:wikipedia#Secondary_Wikipedia_links) | historic=aircraft + manufacturer=Boeing + manufacturer:wikipedia=en:Boeing | |
| model=* |
|
Model of the element | historic=aircraft + manufacturer=Boeing + model=747 | |
| model:wikidata=* |
|
Q-ID of the Wikidata element representing the model (standard meaning of the suffix as defined by Key:wikidata#Secondary_Wikidata_links) | historic=aircraft + manufacturer=Boeing + model=747 + model:wikidata=Q179 | |
| model:wikipedia=* |
|
Localized title of the Wikipedia page describing the model (standard meaning of the suffix as defined by Key:wikipedia#Secondary_Wikipedia_links) | historic=aircraft + manufacturer=Boeing + model=747 + model:wikipedia=en:Boeing 747 |
Examples
Rendering
No changes to rendering in typical base layers (like OSM Carto). Specialized renderers which use the model and currently need to check multiple keys (e.g. manufacturer:type=* and model=*) in the long term will be able to rely on one key (model=*) for all artificial element types.
Features/Pages affected
Update pages with the obsolete keys
Update pages with the obsolete keys (manufacturer:type=*, vehicle:wikidata=* and vehicle:wikipedia=*):
- Key:manufacturer:type
- Mark manufacturer:type=* as deprecated in favor of model=*
- Key:vehicle:wikidata
- Mark vehicle:wikidata=* as deprecated in favor of model:wikidata=*
- Key:vehicle:wikipedia
- Mark vehicle:wikipedia=* as deprecated in favor of model:wikipedia=*
- Deprecated features
- Add the keys cited above to the Deprecated features list
Update pages with the correct keys
Update pages with the correct keys (manufacturer=*, manufacturer:wikidata=*, manufacturer:wikipedia=*, model=*, model:wikidata=* and model:wikipedia=*):
- Key:manufacturer
- Add a link to manufacturer:wikipedia=* (the link to manufacturer:wikidata=* is already present)
- Key:model
- Add links to model:wikidata=* and model:wikipedia=*
- Add the definition "model=* should contain a designation that allows to distinguish a class of objects with the same design and/or charateristics amongst those produced by the same manufacturer. Generic classifications which are not limited to a single manufacturer don't belong to model=* but rather to domain-specific tags (for example aircraft:type=* for historic=aircraft)."
- Tag:emergency=siren#Additional_tags
- Add model=*, model:wikidata=* and model:wikipedia=* as possible tags
- Tag:historic=vehicle#Additonal_tags
- Add manufacturer=*, manufacturer:wikidata=*, manufacturer:wikipedia=*, model=*, model:wikidata=* and model:wikipedia=* as possible tags
- Tag:historic=aircraft#Additional_tags
- Add model=*, model:wikidata=* and model:wikipedia=* as possible tags
- Make it more clear that aircraft:type=* should not be used for the model
- Key:wikidata#Secondary_Wikidata_links
- Add manufacturer:wikidata=*, model:wikidata=* as possible tags
- SPARQL_examples#Decommissioned_aircraft_by_manufacturer
- Edit the query to use both aircraft:model:wikidata=* and model:wikidata=* as possible model tags
- SPARQL_examples#Outdoor_warning_sirens_by_make_and_model
- Edit the query to use both siren:model:wikidata=* and model:wikidata=* as possible model tags
External discussions
- Talk:Tag:historic=vehicle#How_can_the_model_of_vehicle_.28and_its_wiki_links.29_be_tagged.3F => Discussion that started this proposal
- Talk:Key:manufacturer:type => Discussion on manufacturer:type=*, where it has been proposed to be deprecated
- https://lists.openstreetmap.org/pipermail/tagging/2022-March/064197.html => Request For Comment
Comments
Please comment on the discussion page.
Voting
Voting on this proposal has been closed.
It was approved with 25 votes for, 0 votes against and 2 abstentions.
I approve this proposal. -- Something B (talk) 10:51, 13 November 2022 (UTC)- I approve this proposal. --- Kovposch (talk) 11:06, 13 November 2022 (UTC)
I have comments but abstain from voting on this proposal. As someone who invented vehicle:wikidata=*/vehicle:wikipedia=* (to make removal of invalid wikipedia=* wikidata=* easier, not because I think that it is useful to add it) I am fine with replacing it with model:wikidata=*/model:wikipedia=* though I have not reviewed (so far) other parts of proposal . It is likely that I added most or nearly all vehicle:wikidata=*/vehicle:wikipedia=* And for ones I added: as far as I am concerned, feel free to migrate them to this new tags. See also this discussion --Mateusz Konieczny (talk) 11:15, 13 November 2022 (UTC)
- BTW, you may like https://matkoniecz.github.io/OSM-wikipedia-tag-validator-reports/ if you care about stuff like "For example a lot of historic=vehicle and historic=tank are mapped using name=*, wikidata=* and wikipedia=* to represent their model, as can be seen with the Overpass query https://overpass-turbo.eu/s/1h9E and with the Sophox query https://tinyurl.com/y9744cgq " Mateusz Konieczny (talk) 11:20, 13 November 2022 (UTC)
- Thank you for the note about migrating. Regarding the wiki* QA, very cool, to explore this problem some time ago I also created other Sophox queries that I saved in User:Danysan#Useful_Sophox_SPARQL_queries. --Danysan (talk) 13:05, 13 November 2022 (UTC)
- BTW, you may like https://matkoniecz.github.io/OSM-wikipedia-tag-validator-reports/ if you care about stuff like "For example a lot of historic=vehicle and historic=tank are mapped using name=*, wikidata=* and wikipedia=* to represent their model, as can be seen with the Overpass query https://overpass-turbo.eu/s/1h9E and with the Sophox query https://tinyurl.com/y9744cgq " Mateusz Konieczny (talk) 11:20, 13 November 2022 (UTC)
- I approve this proposal. -- Fanfouer (talk) 21:18, 13 November 2022 (UTC)
- I approve this proposal. --Lejun (talk) 07:28, 14 November 2022 (UTC)
- I approve this proposal. --FreeExec (talk) 07:47, 14 November 2022 (UTC)
- I approve this proposal. —- Discostu36 (talk) 09:34, 14 November 2022 (UTC)
- I approve this proposal. --Mueschel (talk) 12:05, 14 November 2022 (UTC)
- I approve this proposal. --Fabi2 (talk) 12:59, 14 November 2022 (UTC)
- I approve this proposal. --Nadjita (talk) 17:35, 14 November 2022 (UTC)
- I approve this proposal. --Derek Hunter (talk) 17:42, 14 November 2022 (UTC)
- I approve this proposal. --Davidoskky (talk) 17:53, 14 November 2022 (UTC)
- I approve this proposal. --Ydel (talk) 18:23, 14 November 2022 (UTC)
- I approve this proposal. --KoiAndBlueBird (talk) 19:12, 15 November 2022 (UTC){{
- I approve this proposal. --Dafadllyn (talk) 16:29, 17 November 2022 (UTC)
- I approve this proposal. Great proposal. I wonder if brand=* has also been abused often in cases where manufacturer=* is meant--501ghost (talk) 20:45, 19 November 2022 (UTC)
- I approve this proposal. --Martin minheim (talk) 12:34, 20 November 2022 (UTC)
- I approve this proposal. --Cmap99 (talk) 12:54, 20 November 2022 (UTC)
- I approve this proposal. --Nw520 (talk) 13:53, 20 November 2022 (UTC)
- I approve this proposal. --Ivanbranco (talk) 14:15, 20 November 2022 (UTC)
- I approve this proposal. --Reino Baptista (talk) 16:36, 20 November 2022 (UTC)
- I approve this proposal. ---jub- (talk) 08:23, 21 November 2022 (UTC)
- I have comments but abstain from voting on this proposal. I think that those tags should not be replaced, but just deleted because they aren't geodata. The purpose of OSM is not to provide detailed spec sheets for everything that exists on earth. --Fkv (talk) 07:10, 23 November 2022 (UTC)
- I approve this proposal. Contrary to the vote above, I believe these keys have largely been used in a manner that respects the ground-verifiability principle, and there are obvious use cases in detailed 3D rendering. I support unifying these keys. In fact, I keep learning about even more model-like keys such as post_box:design=*. We should probably replace them with model=* at some point, as a followup to this proposal. – Minh Nguyễn 💬 05:57, 24 November 2022 (UTC)
- I approve this proposal. --Uboot (talk) 20:00, 24 November 2022 (UTC)
- I approve this proposal. --CatSu (talk) 20:18, 24 November 2022 (UTC)
- I approve this proposal. If some mapper wants to put them in, then it is better to have a single (approved) key rather than multiples of unapproved keys. --Warin61 (talk) 02:18, 27 November 2022 (UTC)