Automated edits/Math1985/Musical instrument

From OpenStreetMap Wiki
Jump to: navigation, search

Proposal

At 1 January 2014, all objects tagged with shop=musical_instruments have been changed into shop=musical_instrument.

Rationale

Some shops for music instruments were tagged with the singular form shop=musical_instrument, while others were tagged with the plural form shop=musical_instruments. Having only one form makes life easier for both mappers and data consumers.

I realize that automatic edits are often undesirable. When badly executed, automatic edits can easily introduce additional mistakes, especially when executed by mappers without local knowledge. Automatic edits can also have undesired side-effects. Moreover, automatic edits might offend mappers who do not agree with the edit.

In particular, I recognize that it is important that:

  1. automatic edits have wide community support;
  2. automatic edits do not introduce mistakes or otherwise destroy the work of local mappers.

I believe that in this case, both of these requirements are satisfied.

There is wide community support for the singular form, both by actual mappers (1356 instances of the singular versus 126 instances of the plural), and by members of the tagging mailing list (a vote shows that the singular is preferred by 11 out of 12 voters).

Moreover, the difference is only grammatical, so there is no risk that mistakes will be introduced.

In addition, I have taken the following measurements to minimize the risk of negative side effects:

  • I have followed, of course, the Automated_Edits_code_of_conduct and the Mechanical Edit Policy.
  • I have created the current page to document this automatic edit.
  • I have discussed this edit at the tagging mailing list. Although not formally required, in order to guarantee community support, I have invite list members to vote on this automatic edit. I will not proceed without either 8 unanimous approval votes or 15 total votes with 2/3 approval. The vote has been unanimously accepted (10 approvals, 0 rejections).
  • Although not a formal requirement either, I have asked the Data Working Group for permission before carrying out this edit. The Data Working Group has indicated that they do not usually give explicit permission for mechanical edits. However, they did not see obvious flaws with the proposal.

Technical implementation

  • I have used JOSM combined with Overpass ( url ).
  • I have done this edit within one changeset with tags "mechanical=yes" and "comment=Rename shop=musical_instruments to shop=musical_instrument, see http://wiki.openstreetmap.org/w/index.php?title=Mechanical_Edits/Math1985/Musical_instrument".
  • This will be a one-time edit.
  • I have allowed users to opt-out. If users want me not to touch some objects, they could leave the relevant object id's on this page, or contact me by e-mail. No opt-outs have been received.

Voting

Voting open date: 2 November 2013. Voting closing date: 16 November 2013.

Please use {{vote|yes}} or {{vote|no}} and give your reasons to oppose. Use ~~~~ to sign your user name & date.

  • I approve this proposal I approve this proposal. Math1985 (talk) 20:59, 2 November 2013 (UTC)
  • I approve this proposal I approve this proposal. --Danstowell (talk) 21:07, 2 November 2013 (UTC)
  • I approve this proposal I approve this proposal. --Csmale (talk) 21:23, 2 November 2013 (UTC)
  • I approve this proposal I approve this proposal. because the current usage is 10 times more, but I'd instictivly prefer the plural form as it seems more natural --Dieterdreist (talk) 21:34, 2 November 2013 (UTC)
  • I approve this proposal I approve this proposal. --Imagic (talk) 21:47, 2 November 2013 (UTC)
  • I approve this proposal I approve this proposal. but I agree with Dieterdreist -- Bigfatfrog67 (talk) 23:42, 2 November 2013 (UTC)
  • I approve this proposal I approve this proposal. but I agree with Dieterdreist -- HillWithSmallFields (talk) 17:39, 5 November 2013 (UTC)
  • I approve this proposal I approve this proposal. but I agree with Dieterdreist -- nounours77 19:36, 10 November 2013 (UTC)
  • I approve this proposal I approve this proposal. --Papou but I (once again) stress that the syntax shop=something prevents the shop selling anything else (";" being strictly forbidden) while shop=yes + something=? or something=shop do not. And, of course, I agree with Dieterdreist so that at least they can sell more than one. And, regarding Tag:shop=musical_instrument, I (once again) stress that if a name=* tag is nice to go there, a probable website=* is even more to know whether you should go.--Papou (talk) 20:31, 10 November 2013 (UTC)
  • I approve this proposal I approve this proposal. but I also feel the plural from to be more natural. --Chaos99 (talk) 07:11, 11 November 2013 (UTC) (And I hereby vote to make this mechanical edit proposal the new golden master of mechanical edit proposals. Well done.)

Contact

Matthijs Melissen, osm@matthijsmelissen.nl