Talk:Key:manufacturer:type

From OpenStreetMap Wiki
Jump to navigation Jump to search

What does type refer to?

This key deals with concept of type associated to manufacturer. What does it mean?
Is it a classification of companies or a particular model in a whole brand? In case of the model of wind turbine, I would have thought about simpler model=*.
No offense but:type keys should be avoided as type suffix doesn't bring any new information Fanfouer (talk) 00:26, 19 September 2019 (UTC)

Looking at usage on TagInfo I think it's pretty clear that the key is used to indicate the model designation or type designation, hence the suffix type. Having said this, I agree with you that the syntax referring to manufacturer doesn't seem correct and using type in this specific way can be confusing compared to how it's used elsewhere in OSM. model=* could be a good alternative and since it's already somewhat in use I've started its documentation. Also note that this key can be found as a subkey, for example in generator:model=*.--TOGA (talk) 23:20, 9 April 2020 (UTC)

Duplicates of model=*

Following @M!dgard: edits (thank you), this key sounds to duplicate model=*. :type seems to qualify manufacturer instead of what the company actually produces.
If information provided regards a particular kind of object produced by a manufacturer, why using :type related to manufacturer?
I definetly prefer model=* which doesn't involve namespacing for such a common thing and prevent yet another :type usecase. Fanfouer (talk) 21:54, 1 July 2020 (UTC)

I can relate with this tag's inventor in that a prefix makes sense to group manufacturer and model together in alphabetical tag lists (like in JOSM). They are after all related. But I can't think of any prefix that would make sense.
Someone could write a deprecation proposal for manufacturer:type (make sure to link to it on the tag's page when you do). —M!dgard [ talk ] 22:40, 1 July 2020 (UTC)
Check out Proposed features/Manufacturer and Model, it includes deprecating manufacturer:type=* and marking model=* as approved --Danysan (talk) 18:53, 28 March 2022 (UTC)
Sounds really great, thank you ! Fanfouer (talk) 20:45, 28 March 2022 (UTC)