Talk:Quality Assurance Tools script

From OpenStreetMap Wiki
Jump to: navigation, search

Flag error to server

Hi! Thanks a lot for this great script which I tested yesterday. I think that something is broken with flagging automatically to the keepright-server. Yesterday I corrected some errors with impossible angles and solved them. Everytime I clicked on the Button Qat script correctedBtn.png to flag this error to the server. However, when I solved all 100 errors, I wanted to download some new, but I got the same ones. Today I also get the same ones. I looked on the map in keepright.at and realized, that the same (already solved) errors are still visible on the map- So I suppose something is brokem with the flag. Thanks! --Poppei82 (talk) 09:21, 3 May 2013 (UTC)

Hi, thanks to you for translating the wiki page in Deutsch :)
I can't reproduce the bug... I did these steps:
  • I opened this zone in josm (max zoom on the roundabout)
  • qat_script --> keepright --> roundabout --> wrong direction
  • clicked "Go to next" (so that josm downloads data)
  • clicked the button "Error corrected"
  • in the web browser: I reloaded the KeepRight link and the the error was flagged as corrected (marker with smiling face)
Could you please try this and/or tell me your steps to reproduce the bug? I even tried to flag as corrected an "extreme angle" error and it seems it works too. Groppo (talk) 17:01, 3 May 2013 (UTC)
Hi! Sorry, During the weekend I had no computer to test that. Now it works perfect. I will test it in the next days/weeks. Last time I did that was with impossible angles and script version 0.1.0 and downloaded 100 errors. OK, we'll see. But for now I think the script works fine. :-) --Poppei82 (talk) 08:46, 6 May 2013 (UTC)
Hmm sorry, but it seems that the bug isn't solved. Have a look at http://www.openstreetmap.org/browse/way/217573064 Tomorrow in the morning I fixed it and pressed the "error corrected" button. Now in the evening (after restartet JOSM) I downloaded some more errors. And this error still appears as non-solved. But: it seems that the way is fixed, but not (yet?) rendered by Mapnik? Howver, the keepright-error shouldn't appear anymore. --Poppei82 (talk) 16:53, 6 May 2013 (UTC) edit: keepright error #: http://www.keepright.at/report_map.php?schema=4&error=46768247
There was a bug on the url to give feedback to KeepRight regarding errors from central Europe, I'm sorry :-( Please, update to v0.2. Thank you for reporting this. Groppo (talk) 20:57, 7 May 2013 (UTC)

Automatic selection of error (KeepRight)

Hi again. :-) I wanted to ask for a feature: when using keepright, the error is automatically selected in JOSM. For example: when I click on the JOSM-button using the keepright webpage, the roundabout with the wrong direction is selected so that I only have to press the "r" button to reverse the direction. Using the qa-script, I have to select the roundabout manually. Implementing the autoselection-feature would minimize mouseclicks and make the error correction easier. :-) Thanks! --Poppei82 (talk) 09:04, 6 May 2013 (UTC)

It would be better but unfortunately this is not possible.
The script downloads errors from KeepRight as GPX file. You can dowload this file manually too: just go to KeepRight website and click on the GPX link at the bottoom. In this file there is not the OSM id of the node or way with the error, so qat_script just know the area where the error is, but not which element is affected (and therefore cannot select it).
I could ask KeepRight developer if he could add OSM id in GPX files but I don't know if it is feaseble/convenient to change KeepRight processes just for qat_script (though maybe other applications could benefit from this change). I will add here any news on this matter. Groppo (talk) 10:16, 6 May 2013 (UTC)
Good news! Harald Kleiner (KeepRight developer) has kindly added OSM ids to errors files, so now (v0.3) "when using keepright, the error is automatically selected in JOSM".Groppo (talk) 10:46, 19 May 2013 (UTC)
Thank you very much! :-) --Poppei82 (talk) 14:13, 20 May 2013 (UTC)

Temporary ignored errors

Hallo!

Can you please add a downloading of fixed (temp. ignored) errors from KeepRight? I need this feature for counting of errors which are fixed by me and other OSM-ers.

Thanks! --Edward17 (talk) 12:52, 27 March 2015 (UTC)

Hi, sorry for the delay. I don't think it is possible to download only fixed errors from KeepRight.
If you are just interested in the number of fixed errors, can't you simply create a favourite zone and compare the number of errors before and after the corrections, by downloading them again?--Groppo (talk) 20:33, 30 March 2015 (UTC)
Thanks for the answer. The idea is good, but there is one problem: I hadn't counted the number of errors before we fixed them. That is why I'm asking about it. --Edward17 (talk) 20:25, 31 March 2015 (UTC)
I'm sorry. Probably it's too late, but if KeepRight's web page is still showing the fixed errors with a smiling icon you could: save the web page, open it in a text editor and count the occurrences of the smiling icon ("zapangel.png") in the code. It's a workaround but better than counting the icons one by one.--Groppo (talk) 17:14, 3 April 2015 (UTC)
Yes, you are right: KeepRight's errors database is updated, fixed by me errors are not shown.
But thanks for a way of calculating! --Edward17 (talk) 10:56, 4 April 2015 (UTC)

The difference between "area" and "zone" in preferences

Is there some difference between phrases "favourite area" and "favourite zone" in second tab (Favourite area) in preferences dialog? Why in one places "area" is used, and in other - "zone"?
P. S. Sorry for my bad English. --Edward17 (talk) 20:31, 31 March 2015 (UTC)

There isn't any difference. I will correct it in the next version (it may take some time) so that it is always used the word "zone". Thank you for reporting it!--Groppo (talk) 17:15, 3 April 2015 (UTC)
Thanks for answer and for fixing it! --Edward17 (talk) 10:56, 4 April 2015 (UTC)

Translation in Russian

I (Edward17) and Xmypblu translated this script into Russian language: https://wiki.openstreetmap.org/wiki/RU:Quality_Assurance_Tools_script/Translation

Can you please add this translation to the script?

P. S. I wanted to make MessagesBundle_ru.properties file, but I have problem with encoding. If I just copy text from wiki-page into file, I see in JOSM strange symbols instead of cylillic letters.
Do you know about this bug? Can you fix it? --Edward17 (talk) 20:03, 5 April 2015 (UTC)

Thank you for the translation.
The text must be converted to unicode with native2ascii before you can use it, otherwise you will see those symbols.
Please, use the following file and tell me if everything looks right: MessagesBundle_ru.properties. --Groppo (talk) 19:00, 8 April 2015 (UTC)
Thanks, ewerything works correctly. --Edward17 (talk) 09:30, 10 April 2015 (UTC)
I have added the Russian translation to the development version.--Groppo (talk) 20:26, 14 April 2015 (UTC)