Proposed features/Manufacturer and Model

From OpenStreetMap Wiki
Jump to navigation Jump to search
Manufacturer and Model
Proposal status: Approved (active)
Proposed by: Danysan
Applies to: node area
Definition: Standardization of the tagging of manufacturer and model of artificial elements
Drafted on: 2022-03-27
RFC start: 2022-03-27
Vote start: 2022-11-13
Vote end: 2022-11-27


Proposal

Rationale

There are many tags which represent an type of artificial object which has a manufacturer and a model.

With "model" we intend here a designation that allows to distinguish a class of objects with the same design and/or charateristics amongst those produced by the same manufacturer. Generic classifications which are not limited to a single manufacturer don't belong here and are already handled by domain-specific tags (for example aircraft:type=* for historic=aircraft) (more details about this in the discussion page).

Some of the features that can have a manufacturer and a model are:

Current situation

Tags manufacturer=* and model=* are already approved to represent the informations of manufacturer and model. Currently however there is some confusion about the keys which can be used for this purpose:

Page Manufacturer Model
Key:manufacturer manufacturer=* (approved), manufacturer:wikidata=* model=*, manufacturer:type=*
Key:manufacturer:wikidata manufacturer:wikidata=*
Key:model manufacturer=* model=* (approved), manufacturer:type=*, siren:model=*
Key:manufacturer:type manufacturer:type=* "is a bad tag, since it does not express the type of manufacturer as one would think.", model=*
Tag:man_made=street_cabinet#Tagging manufacturer=* model=*
Tag:man_made=utility_pole#How_to_map manufacturer=*
Tag:pipeline=valve#Tagging manufacturer=*
Tag:man_made=pump manufacturer=*
FR:Tag:amenity=ticket_validator#Combinaisons_utiles (only in the french wiki) manufacturer=* model=*
Tag:emergency=siren#Additional_tags manufacturer=*, manufacturer:wikidata=* siren:model=*
SPARQL_examples#Outdoor_warning_sirens_by_make_and_model manufacturer:wikidata=* siren:model:wikidata=*
Tag:emergency=fire_hydrant#Optional_tags manufacturer=* model=*
Tag:historic=vehicle#Additonal_tags manufacturer=*, manufacturer:wikidata=*
Key:vehicle:wikidata vehicle:wikidata=* "appeared in 2021 and is quite rare and used by very limited number of mappers (maybe even just one)."
Key:vehicle:wikipedia vehicle:wikipedia=* "appeared in 2021 and is quite rare and used by very limited number of mappers (maybe even just one)."
Tag:historic=aircraft#Additional_tags manufacturer=*, manufacturer:wikidata=* aircraft:type=*, model=*, aircraft:model=*
SPARQL_examples#Decommissioned_aircraft_by_manufacturer manufacturer:wikidata=* aircraft:model:wikidata=*
Proposed_features/Extended_tags_for_Key:Surveillance#Camera camera:make=*, sensor:make=* camera:model=*, sensor:model=*
Proposed features/Fire Hydrant Extensions (part 2)#New_Tags Approved manufacturer=* Approved model=*

Recap of keys to represent the manufacturer:

LOADING TAG LIST... (If you do not see this tag list, you need to enable Javascript)

This table is auto-generated. See Template:Taglist for a documentation on it.

Recap of keys to represent the model:

LOADING TAG LIST... (If you do not see this tag list, you need to enable Javascript)

This table is auto-generated. See Template:Taglist for a documentation on it. Other minor keys can be found at https://taginfo.openstreetmap.org/keys/model#similar .


Sometimes this confusion can lead to mapping errors. For example a lot of historic=vehicle and historic=tank are mapped using name=*, wikidata=* and wikipedia=* to represent their model, as can be seen with the Overpass query https://overpass-turbo.eu/s/1h9E and with the Sophox query https://tinyurl.com/y9744cgq . This is clearly wrong, as name=*, wikidata=* and wikipedia=* should represent the object itself and not its model or some other charateristic. Reading from their wiki page it appears that vehicle:wikidata=* and vehicle:wikipedia=* were born to fix this, but

Rationale of the proposal

The objective of this proposal is to create a common standard to represent manufacturer, model and related Wiki links across all element types which are an instances of a model.

Given that the manufacturer=* and model=* keys are already used and approved and their wiki pages describe correctly they will remain the reference tags.

For both of them there is the possibility to add a link to wikidata or wikipedia through the tags manufacturer:wikidata=*, manufacturer:wikipedia=*, model:wikidata=* and model:wikipedia=*. manufacturer:wikidata=* is already documented in Key:manufacturer:wikidata, while for the other three tags the auto-generated pages Key:manufacturer:wikipedia, Key:model:wikidata and Key:model:wikipedia already explain sufficiently well the meaning of the combination.

I propose to update the wiki pages cited above to clean up the confusion and suggest the use manufacturer=* and model=* instead of the previous alternatives. In the case of manufacturer:type=*, vehicle:wikidata=* and vehicle:wikipedia=* I also propose the deprecation. On the other side, I don't propose the deprecation of other *:model=* subkeys because the world is full of edge cases where someone could want to tag separately different parts of elements that to the outsider look one single piece (more details about this in the discussion page).

Tagging

Key Element Description Count Example
manufacturer=* node area Manufacturer historic=aircraft + manufacturer=Boeing
manufacturer:wikidata=* node area Q-ID of the Wikidata element representing the manufacturer (standard meaning of the suffix as defined by Key:wikidata#Secondary_Wikidata_links) historic=aircraft + manufacturer=Boeing + manufacturer:wikidata=Q66
manufacturer:wikipedia=* node area Localized title of the Wikipedia page describing the manufacturer (standard meaning of the suffix as defined by Key:wikipedia#Secondary_Wikipedia_links) historic=aircraft + manufacturer=Boeing + manufacturer:wikipedia=en:Boeing
model=* node area Model of the element historic=aircraft + manufacturer=Boeing + model=747
model:wikidata=* node area Q-ID of the Wikidata element representing the model (standard meaning of the suffix as defined by Key:wikidata#Secondary_Wikidata_links) historic=aircraft + manufacturer=Boeing + model=747 + model:wikidata=Q179
model:wikipedia=* node area Localized title of the Wikipedia page describing the model (standard meaning of the suffix as defined by Key:wikipedia#Secondary_Wikipedia_links) historic=aircraft + manufacturer=Boeing + model=747 + model:wikipedia=en:Boeing 747

Examples

Type Element Tags before Possible tags after
Aircraft model Node 4196379327 name=UB-736
tourism=attraction
historic=aircraft
aircraft:type=DC-3
name=UB-736
tourism=attraction
historic=aircraft
aircraft:type=airliner
manufacturer=Douglas
manufacturer:wikidata=Q651778
manufacturer:wikipedia=en:Douglas Aircraft Company
model=DC-3
model:wikidata=Q190211
model:wikipedia=en:Douglas DC-3
Tank model Node 7152627919 historic=tank
wikidata=Q6713481
wikipedia=en:M106 mortar carrier
historic=tank
manufacturer=FMC
manufacturer:wikidata=Q899183
manufacturer:wikipedia=en:FMC Corporation
model=M106
model:wikidata=Q6713481
model:wikipedia=en:M106 mortar carrier
Wind turbine model Node 1710264979 power=generator
generator:source=wind
generator:method=wind_turbine
generator:output:electricity=3.3 MW
manufacturer=Vestas
manufacturer:type=V112
power=generator
generator:source=wind
generator:method=wind_turbine
generator:output:electricity=3.3 MW
manufacturer=Vestas
manufacturer:wikidata=Q868259
manufacturer:wikipedia=en:Vestas
model=V112
model:wikidata=Q68061130
Vehicle (only manufacturer known) historic=vehicle
manufacturer=Opel
manufacturer:wikidata=Q40966
historic=vehicle
manufacturer=Opel
manufacturer:wikidata=Q40966
Vehicle (only manufacturer and model family known) historic=vehicle
manufacturer=Opel
manufacturer:wikidata=Q40966
vehicle:wikidata=Q1350
historic=vehicle
manufacturer=Opel
manufacturer:wikidata=Q40966
model=Astra
model:wikidata=Q1350
Vehicle (manufacturer and model known) historic=vehicle
manufacturer=Opel
manufacturer:wikidata=Q40966
vehicle:wikidata=Q898479
historic=vehicle
manufacturer=Opel
manufacturer:wikidata=Q40966
model=Astra F
model:wikidata=Q898479
Vehicle (manufacturer, model and submodel known) historic=vehicle
manufacturer=Opel
manufacturer:wikidata=Q40966
vehicle:wikidata=Q96742533
historic=vehicle
manufacturer=Opel
manufacturer:wikidata=Q40966
model=Astra F Cabriolet
model:wikidata=Q96742533
Vehicle (manufacturer, model and version known)
Distinguish Jaguar S-Type (1999) and Jaguar S-Type (1963)
historic=vehicle
manufacturer=Jaguar
manufacturer:wikidata=Q30055
vehicle:wikidata=Q582111
historic=vehicle
manufacturer=Jaguar
manufacturer:wikidata=Q30055
manufacturer:wikipedia=en:Jaguar Cars
model=S-Type (1999)
model:wikidata=Q582111
model:wikipedia=en:Jaguar S-Type (1999)
Ship class historic=ship
vehicle:wikidata=Q287632
vehicle:wikipedia=en:Gerald R. Ford-class aircraft carrier
historic=ship
manufacturer=United States Navy
manufacturer:wikidata=Q11220
manufacturer:wikipedia=en:United States Navy
model=Gerald R. Ford class
model:wikidata=Q287632
model:wikipedia=en:Gerald R. Ford-class aircraft carrier

Rendering

No changes to rendering in typical base layers (like OSM Carto). Specialized renderers which use the model and currently need to check multiple keys (e.g. manufacturer:type=* and model=*) in the long term will be able to rely on one key (model=*) for all artificial element types.

Features/Pages affected

Update pages with the obsolete keys

Update pages with the obsolete keys (manufacturer:type=*, vehicle:wikidata=* and vehicle:wikipedia=*):

Update pages with the correct keys

Update pages with the correct keys (manufacturer=*, manufacturer:wikidata=*, manufacturer:wikipedia=*, model=*, model:wikidata=* and model:wikipedia=*):

External discussions

Comments

Please comment on the discussion page.

Voting

Voting closed

Voting on this proposal has been closed.

It was approved with 25 votes for, 0 votes against and 2 abstentions.

BTW, you may like https://matkoniecz.github.io/OSM-wikipedia-tag-validator-reports/ if you care about stuff like "For example a lot of historic=vehicle and historic=tank are mapped using name=*, wikidata=* and wikipedia=* to represent their model, as can be seen with the Overpass query https://overpass-turbo.eu/s/1h9E and with the Sophox query https://tinyurl.com/y9744cgq " Mateusz Konieczny (talk) 11:20, 13 November 2022 (UTC)
Thank you for the note about migrating. Regarding the wiki* QA, very cool, to explore this problem some time ago I also created other Sophox queries that I saved in User:Danysan#Useful_Sophox_SPARQL_queries. --Danysan (talk) 13:05, 13 November 2022 (UTC)
  • I approve this proposal I approve this proposal. -- Fanfouer (talk) 21:18, 13 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Lejun (talk) 07:28, 14 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --FreeExec (talk) 07:47, 14 November 2022 (UTC)
  • I approve this proposal I approve this proposal. —- Discostu36 (talk) 09:34, 14 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Mueschel (talk) 12:05, 14 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Fabi2 (talk) 12:59, 14 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Nadjita (talk) 17:35, 14 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Derek Hunter (talk) 17:42, 14 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Davidoskky (talk) 17:53, 14 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Ydel (talk) 18:23, 14 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --KoiAndBlueBird (talk) 19:12, 15 November 2022 (UTC){{
  • I approve this proposal I approve this proposal. --Dafadllyn (talk) 16:29, 17 November 2022 (UTC)
  • I approve this proposal I approve this proposal. Great proposal. I wonder if brand=* has also been abused often in cases where manufacturer=* is meant--501ghost (talk) 20:45, 19 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Martin minheim (talk) 12:34, 20 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Cmap99 (talk) 12:54, 20 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Nw520 (talk) 13:53, 20 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Ivanbranco (talk) 14:15, 20 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Reino Baptista (talk) 16:36, 20 November 2022 (UTC)
  • I approve this proposal I approve this proposal. ---jub- (talk) 08:23, 21 November 2022 (UTC)
  • I abstain from voting but have comments I have comments but abstain from voting on this proposal. I think that those tags should not be replaced, but just deleted because they aren't geodata. The purpose of OSM is not to provide detailed spec sheets for everything that exists on earth. --Fkv (talk) 07:10, 23 November 2022 (UTC)
  • I approve this proposal I approve this proposal. Contrary to the vote above, I believe these keys have largely been used in a manner that respects the ground-verifiability principle, and there are obvious use cases in detailed 3D rendering. I support unifying these keys. In fact, I keep learning about even more model-like keys such as post_box:design=*. We should probably replace them with model=* at some point, as a followup to this proposal. – Minh Nguyễn 💬 05:57, 24 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --Uboot (talk) 20:00, 24 November 2022 (UTC)
  • I approve this proposal I approve this proposal. --CatSu (talk) 20:18, 24 November 2022 (UTC)
  • I approve this proposal I approve this proposal. If some mapper wants to put them in, then it is better to have a single (approved) key rather than multiples of unapproved keys. --Warin61 (talk) 02:18, 27 November 2022 (UTC)