Talk:Tag:man made=storage tank

From OpenStreetMap Wiki
Jump to: navigation, search

Map rendering

Apparently building=yes has to be added so that element is rendered.--Absay (talk) 08:06, 22 February 2017 (UTC)

Please do not do it this way. Storage tank is not a building. Tagging for renderer is wrong. See Buildings#Don.27t_tag_for_the_renderer.
Chrabros (talk) 08:26, 25 February 2017 (UTC)
I'm well aware one should not tag for the renderer. But the map example on the page links to a place full of tanks where each one of them has been tagged as buildings.--Absay (talk) 08:39, 25 February 2017 (UTC)
Clearly someone was seduced. But we should not spread it further. Chrabros (talk) 08:45, 25 February 2017 (UTC)
Dont' worry. I only mapped one storage tank. Will revert my changes. Also, just a few blocks south east from the example map, water tanks were also tagged as buildings, which by the same logic are not buildings either, I assume? I thought looking at some maps in Germany (e.g. Berlin) would give me good insight on how more experienced people are mapping stuff in important cities but I guess I should look at some other more trustable regions or ask here when in doubt. I appreciate the quick answers in this case.
Also, should that map example (bad example anyway!) be removed from the main article? And recommend not to tag storage tank areas as buildings? --Absay (talk) 22:22, 25 February 2017 (UTC)
Nearly 45% use building with storage_tank. So one can not speak of an exception. There is an issues on this topic, but as far as I can see from it no solution. But that would be important.--geozeisig (talk) 10:25, 28 February 2017 (UTC)
"So one can not speak of an exception", sorry but I don't get what you mean by this. Are you trying to encourage mapping storage tanks as buildings because almost half of them are like that? Or are you reinforcing the idea of tagging them as buildings is a bad practice? --Absay (talk) 17:07, 28 February 2017 (UTC)
Nevertherless it would be a great idea to render these things in the first place, i. e. let the renderer consider them as buildings instead of explicitly mapping them as such. --Gausserrorfunction (talk) 21:48, 16 June 2017 (UTC)

Add made-of

It could be made of

  • Wood
  • Metal
  • Plastic
  • Cement
  • Etc.

Jidanni (talk) 02:49, 12 March 2017 (UTC)

You can use material=* fot this. Chrabros (talk) 04:48, 12 March 2017 (UTC)

Add above-ground

It could be

  • Elevated
  • At surface level
  • Partially submerged below the ground line
  • Underground
  • etc.

Jidanni (talk) 02:50, 12 March 2017 (UTC)

See location=* Chrabros (talk) 05:33, 12 March 2017 (UTC)
I added location=*. Underground seems to be not implemented yet per Google, so I left it out. Instead of partially_underground I considered semi-underground but this is mostly used for waste containers while the former is more used on houses.--Jojo4u (talk) 11:04, 17 June 2017 (UTC)

Add Capacity

It could be

  • 100 metric tons (water) (100,000 liters)
  • 1 metric ton (1,000 liters)
  • etc.

Big difference. Jidanni (talk) 02:55, 12 March 2017 (UTC)

I added the tag. --Jojo4u (talk) 10:31, 17 June 2017 (UTC)

Add empty-full

It could be

  • Always empty
  • Always full
  • Seasonally empty
  • Leaky / broken / in disrepair
  • etc,

Jidanni (talk) 02:58, 12 March 2017 (UTC)

Tagging this will probably collide with verification rule. Chrabros (talk) 05:39, 12 March 2017 (UTC)
I agree. The information would be difficult to verify once entered. What would be the use cases? Broken ones can be marked with disused=yes/abandoned=yes (yes a disused tank is still a tank) or disused/abandoned:man_made=storage_tank. --Jojo4u (talk) 10:34, 17 June 2017 (UTC)

Add Drinkable

It could be

  • Drinkable
  • Drinkable only in rescue operation circumstances
  • Unfit for drinking
  • etc.

Jidanni (talk) 03:00, 12 March 2017 (UTC)

Hmm, you cannot drink straight from the storage tank I guess so we should not use drinking_water=*. But probably you could use content=drinking_water. Chrabros (talk) 05:39, 12 March 2017 (UTC)
Could you please elaborate where the distinction water/drinking_water would be important? content=drinking_water sounds good. It's not yet used (taginfo) so I did not add it to the list. Underground drinking water storage tanks which are part of a piped water supply are usually tagged as man_made=reservoir_covered.
See also emergency=water_tank - it's unclear how this tag fits into the whole tagging. I'd see this as POI and not as structure.--Jojo4u (talk) 12:59, 17 June 2017 (UTC)

building=yes ?

In https://github.com/openstreetmap/iD/issues/4265#issuecomment-324636912 he says the wiki is wrong. Jidanni (talk) 13:44, 24 August 2017 (UTC)

I removed this controversial line. Mateusz Konieczny (talk) 10:26, 26 October 2017 (UTC)

AFAIK building definition in OSM is quite wide and includes storage tanks. I propose to recommend tagging with building=storage_tank. Mateusz Konieczny (talk) 10:26, 26 October 2017 (UTC)

Note that around half (100k) man_made=storage_tank are also tagged as building=* ( https://taginfo.openstreetmap.org/tags/man_made=storage_tank#combinations ) Mateusz Konieczny (talk) 10:28, 26 October 2017 (UTC)

When it becomes used like a warehouse...

Mention what to do when... say one moves a lot of boxes into the storage tank. It is still a storage tank, content=boxes ? Or does it now become a shed, shelter, etc.?

Or when it gets converted into a movie theater, without altering the construction... Jidanni (talk) 17:59, 7 December 2017 (UTC)

"Or when it gets converted into a movie theater, without altering the construction..." - sounds like building=storage_tank Mateusz Konieczny (talk) 18:38, 7 December 2017 (UTC)