Talk:StreetComplete/Quests

From OpenStreetMap Wiki
Jump to navigation Jump to search

Increase width of "Question" column?

I think the "Question" column is way too small as the most important column in the table. Any idea how we can extend its width? --rugk (talk) 19:12, 29 September 2017 (UTC)

You could merge the "Notes" and "Country metadata" columns to save horizontal space. Most quests do have neither. --Westnordost (talk) 10:11, 19 April 2018 (UTC)

Yes check.svg --rugk (talk) 10:26, 28 February 2019 (UTC)

Overpass query for cycleway quest

As far as it seems the overpass query for the cycleway quest uses bounding boxes. If anyone knows how to transform this into a format https://overpass-turbo.eu/ can interpret, please do so and add the link. I have no idea…

source is here: https://github.com/westnordost/StreetComplete/blob/a1bceeacffeb6699c8dcc53bcabccb2b8bdbf139/app/src/main/java/de/westnordost/streetcomplete/quests/bikeway/AddCycleway.java#L144-L155

--rugk (talk) 18:58, 21 January 2018 (UTC)

Update notes image?

The notes image has changed, and needs to be updated. It's no longer black punctuation in a white speech balloon, it's now white punctuation. Still in a red disk. --goldfndr (talk) 15:19, 15 February 2018 (UTC)

@Goldfndr (Notes image has been updated some time ago, …) But I just saw your new change. Actually instead of removing the old images, better update them directly. Remember that you can replace the old image with a new one on the site for tzhe image, e.g. here.--rugk (talk) 12:46, 7 July 2018 (UTC)
Yes check.svg --rugk (talk) 10:27, 28 February 2019 (UTC)

Roof Levels vs Building Levels

I was curious why the Roof Shape quest is only applied to buildings tagged with roof:levels=*. I understand that having that tag on the building implies that the roof is not flat. However, considering this house on the right (https://www.mapillary.com/map/im/OYwWTok7ZYTEU6nUhELumQ) or seen from the front (https://www.mapillary.com/map/im/rHmCF-pSEAAXQzU8KEzYbA), I would say building:levels=2 and roof:levels=0, because there is no "level" as such in the roof section of the main part. Am I misunderstanding this or interpreting it differently from other mappers? I would certainly mark the roof:shape=gabled. Compare to the house on the left here (https://www.mapillary.com/map/im/vs_tZ1s-oxr03OYw1X0MkA), which I would certainly tag as building:levels=1, roof:levels=1, roof:shape=gabled. I guess what I'm asking is what to put in SC for the first house. Also, could the roof:shape quest be applied to all or most buildings? --Pkoby (talk) 22:56, 7 May 2018 (UTC)

BTW, I am not certainly sure about this, so I'd rather delegate it. I think it's just because the house levels quest is intended to be asked before the roof type one; and the first one sets the roof:levels. However, for details maybe ask @User:Westnordost. --rugk (talk) 08:39, 20 November 2018 (UTC)

Add column for changeset tag (quest type)?

Example: StreetComplete:quest_type=AddCycleway --MalgiK 00:56, 6 Jan 2019 (UTC)

Where can you even see this tag? And is it's value really so big? --rugk (talk) 10:25, 28 February 2019 (UTC)

Linking to single quests

Linking to a single quest is now possible.

Here is an example link: StreetComplete/Quests#wheelchair_access

I just included that feature in the template for the code links at the right of the table using the "code dir", as this was the easiest thing to do.

However, this is still a little sub-optimal:

  • it's hard for a user to get the link as there is no clickable item (only with an add-on it may be easy, see below). On the other hand, heeadings also don't have this for such a small page.
  • When you use add-ons such as this one to get the link, you likely get the link of the previous item, as the link location is at the right end of the line/page.
  • There is no link for quests (e.g. WIP ones) that do not have any code dir.
  • As you can see from the example above, the "issue" text which includes the link right before, is vertically centered, so the page is opened a little bit below the actual start of the line. So there is some offset in this case.

So possibly some of these things can be improved, but at least we can already link to the quests.

--rugk (talk) 10:07, 13 April 2019 (UTC)

Thanks @MalgiK for your work

Danke @MalgiK für deine Edits, um das hier etwas zu pflegen. :) Thanks @MalgiK for your edits to update this. :) (I'll continue in Eglihs, so everyone understands this.)

Just some notes, I did when editing the wiki:

  • When the changes are already merged in the master branch, I've moved them to the table at the top. I guess, this is not really important, and maybe your way is better, just wanted to make you aware of that, because that is what the text for the seconds table says, there, too. ("When they are merged into the master branch, they should be moved to the upper table.")
  • As for adding the SVG images, I've created a separate GitHub repo, where I've documented how one can do this.
    Of course you don't have to do it in the way (though I'd definitively accept PRs there), and minimizing all the images is likely also a step you don't need to take. However, I'd in any case can suggest two things to make it easier:
    1. Use the template from there for the image upload – it automatically adds the category.
      You don't have to, but I've also always included an alt text/image description for accessibility reasons.
    2. Add the category [[Category:StreetComplete_Quest_Icon]] – which is done automatically if you use the template.
  • Also note on my backlog is this GitHub PR and see this discussion on how to run that Overpass script etc. if you want. By rereading, I also see you could actually generate a wiki page with that script. Maybe that is the better idea anyway? @Mmd: seems to have suggested that long ago there? the test page looks very good IMHO.
    Edit: Moved that topic into a new discussion, as I think this is more appropiate.

But what matters much more is that this is done, so again I'm glad you did it, as I had missed that elaborate task in the past a little. So thanks a lot! (I also just saw the bicycle-related quest icons changed their color – to purple – so yeah, a thing to update yet again.)

Best regards, --rugk (talk) 21:40, 2 August 2020 (UTC)

@rugk Welcome - thanks for these information. Was actually wondering about the procedure how to extract the icons. So I propose to add a note to the file template which refers to separate GitHub repo. By the way, what is the background of the current basic quest order? Would you agree to sort the quests in the same way like you will find it in the app settings "Quest selection"? So starting from quest StreetComplete quest notes.svg, StreetComplete quest road name.svg, StreetComplete quest label.svgStreetComplete quest oneway.svg and so on? --MalgiK (talk) 13:13, 3 August 2020 (UTC)
Hi, yeah feel free to add a note etc. there to make things more clear. As for the order. It's mostly just so that similar quests are grouped together. (e.g. all bicycle quests) Apart from that, it's pretty arbitrary.
As for re-ordering: In the app, AFAIK, it sorts it by the priority it uses when downloading. This could be a good thing to know here too, but I also like that I can see all related, e.g. bicycle quests next to each other. --rugk (talk) 13:28, 3 August 2020 (UTC)
Okay, so then let's don't touch the grouped order. So would you add a column "priority" to the table? Btw., the title of column "Modified tags" might be modified a bit from "Modified tags" to something like "Added tags"? --MalgiK (talk) 14:00, 3 August 2020 (UTC)
@rugk Added a default priority column for testing if it works, please comment. By the way, prio. 1 is "Can you contribute anything to this note?" which can't be unchecked. I tried to find a quest result for this, but after scanning it doesn't shows me any available osm-notes? Will StreetComplete only show notes which were created from the app before? --MalgiK (talk) 15:36, 4 August 2020 (UTC)
By default SC will show only notes with questions, see setting for that. It may also do not show your own notes (maybe it was changed) Mateusz Konieczny (talk) 02:20, 5 August 2020 (UTC)
Thanks, didn't noticed the corresponding checkbox in the settings-dialog. Now i checked it & there were still no notes displayed. Then i did login with osm credentials, after that it works well. Maybe this is a bug (or by intention) that notes are not shown after initial SC app-installation without osm login. --MalgiK (talk) 16:05, 6 August 2020 (UTC)
Based on that description it sounds like a bug or technical limitation Mateusz Konieczny (talk) 16:58, 6 August 2020 (UTC)
I guess, this happens, because SC first needs to download the new quests (in this case: notes) when you change that option, i.e. logging in with creds was maybe an accidential correlation, because you maybe also refreshed the map in between. But this is off-topic here (this is no issue tracker), so back to topic…
As for this quest page, that "question note" quest is actually described in a good way, IMHO. It clearly says there that you only get question-like notes by default. If you missed that, maybe this needs to be reworded – if it is not clear enough, or so?
(Side-note: Also if we are discussion this thing, could you maybe also look at the discussion/idea below about overpass queries? Nobody replied there yet ;).) --rugk (talk) 21:41, 6 August 2020 (UTC)

Future of Overpass queries

The overpass queries are the most frequent and annoying thing that vecomes outdated here IMHO. And they are cumbersome to update manually, because I usually needed to rewrite all these manually in the short Overpass express query langauge…

That's why on my backlog this GitHub PR and this discussion were for a long time. By rereading, I also see you could actually generate a wiki page with that script. Maybe that is the better idea anyway? @Mmd: seems to have suggested that long ago there? the test page looks very good IMHO.

Is this something we want to persue? I like the Wiki template for these overpass queries anyway, and they can be executed with one click from there and are always up-to-date.

And to update, one just has to run that script and paste the output. Sounds like a good thing, IMHO? --rugk (talk) 21:57, 2 August 2020 (UTC)

"Sounds like a good thing, IMHO?" - yes, and it would likely make a maintenance of this page easier (though I have no experience with that) Mateusz Konieczny (talk) 08:00, 7 August 2020 (UTC)
People got confused about an outdated query, ref https://github.com/westnordost/StreetComplete/issues/2072. IMHO this shows this idea here should be taken up (I'm limited on time currently, unfortunately.).
Best would be, IMHO, if the wikipage for overpass queries is also auto-generated on a server or so with the official script by StreetComplete. As such, we'd need another server to run a bot account here (I know people do this on Wikimedia/Wikipedia, but don't know how the SC wiki may be doing that.) --rugk (talk) 12:33, 8 September 2020 (UTC)
Maybe it would be better to remove links to overpass queries altogether. The overpass queries are basically the maximum detail of for which elements it is being filtered. But as you noted yourself, that detail gets outdated very fast and leads to misunderstandings. Furthermore, that detail is already available - in the source code and usually easy to read thanks to the simple syntax. I'd be in favour of just providing a very basic explanation here and for the rest, link to the source code. And with basic, I mean really basic:
Currently it says "publicly accessible nodes and ways with amenity=bicycle_parking (overpass-turbo)". Well, in general the app only (should) ask about publicly accessible things. Also, the amenity=bicycle_parking - feature is defined in the wiki to be on nodes and ways. So the better description would be just "amenity=bicycle_parking", that's it!
If you are ok with this, I can go through the list and update all of these quests. --Westnordost (talk) 18:32, 8 January 2021 (UTC)
Yeah, the intention of the Overpass query was to have a manual way of checking/verifying what elements are used by SC – so people, who cannot read source code, can contribute and practically check what elements SC returns/queries. A map is a lot “more visual” than source code, you see. ;) The auto-generated wiki page with that script would have made that also pretty good to update (to prevent outdated quests) etc. As you don't even use the Overpass-API anymore, do you still have that script? If not, of course we cannot keep that up-to-date and I'd agree to remove all that. I doubt many people even make use of that.
As for the generalization, yeah, I agree, it's really a detail we don't need. Maybe just add a text at the bottom that says “For all/most quests StreetComplete tries to show only publicly accessible elements.”. That would make it more clear. --rugk (talk) 15:09, 11 January 2021 (UTC)
Hey nice, I saw you've changed some things. Note that for Is this way completed? e.g. there is an issue. It says “check_date=*opening_date=*”, i.e. two key tags directly following each other. Also opening hours? --rugk (talk) 00:25, 16 January 2021 (UTC)

bridge quest wiki conflict

The quest What is the structure of this bridge? adds the tag bridge:structure=* to area man_made=bridge objects. The wiki for bridge:structure=* says it is only used for way objects... Could you please double check.

Icon Question Asked for elements Modified tags Resurvey interval Default

priority

Since version Notes Code
a simplistic white arch bridge on a grey background What is the structure of this bridge? man_made=bridge bridge:structure=*
(added values are beam or suspension or arch or truss or cable-stayed or humpback or simple-suspension or floating)
73 4.0 issue
pull request
source

--MalgiK (talk) 07:24, 28 July 2021 (UTC)

See also https://github.com/streetcomplete/StreetComplete/issues/2948 I further modified bridge:structure page and marked areas as allowed Mateusz Konieczny (talk) 07:29, 28 July 2021 (UTC)